Skip to content

Use AssertSame instead of AssertEquals #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2021
Merged

Use AssertSame instead of AssertEquals #113

merged 1 commit into from
Feb 4, 2021

Conversation

TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Feb 3, 2021 •
edited
Loading

In the past, strict types were implemented, parameters were typed, and framework calls included explicit casts.

It is time to make use of this design in assertions as well.

@TavoNiievez TavoNiievez added this to the 2.0.0 milestone Feb 3, 2021
@TavoNiievez TavoNiievez merged commit 03c78fe into Codeception:master Feb 4, 2021
@TavoNiievez TavoNiievez deleted the same_insteadof_equals branch February 4, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@TavoNiievez